-
-
Notifications
You must be signed in to change notification settings - Fork 19.1k
Updating error message to include more details about dataframe #61929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Actually, there are some failing test-indexing.py. Forgot to update the message in the testcase |
Thank you! I am sure this will make it much easier for me to figure out what I need to change! |
Is there anything I need to do before this is reviewed? |
Hi again folks. forks are synced and all tests passed. Will someone be able to review this PR? |
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
I don't know @hasanrashid, and the only contact I've had with him is here in the pull request he donated to pandas. I don't speak for him, and I am not attempting to speak for him. I am pointing out, for the umpteenth time, that pandas, Python, and the Python community are generally incompetent writers, which causes many problems that are willfully neglected, and that relatively easy changes to existing processes would have disproportionately great effects. Hasan, Thank you for your effort and your tenacity. I hope those virtues benefit you, your community, and the rest of us. |
These types of generalizing critiques are not constructive (when describing any group of individuals), and while thank you for breaking down how my last comment could be interpreted as sufficiently unclear, I sense it also partially written to vent frustration like in this other comment. Please remember that open source communities are imperfect systems where largely volunteers, contributors and maintainers, develop software. This pull request unfortunately slipped through the cracks from the maintainers and needed an update with the HEAD of the main branch. The team would still accept pull requests to fix the original issue, and an up-to-date pull request is more likely to be reviewed by a maintainer. |
Not true. "pandas, Python, and the Python community are largely volunteers, contributors and maintainers developing software." See?
This is an excuse by those with power to maintain the status quo. When I volunteer to develop the writing in the software, I'm rejected. |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.Updated error message from
"Must have equal len keys and value when setting with an iterable"
to
f"Length mismatch when setting Dataframe with an iterable: " f"{len(pi)} keys vs {len(value)} values. " f"Keys: {pi}, Values: {value}. " f"Both must have the same length."